Your Time:
Our Time:
← Back to discussions

V6.0.0 breaks child theme player (SoundCloud)

Need help with a different issue? Search the forums or open a new ticket.
Open a support ticket

This topic has 4 replies, 3 voices, and was last updated 9 years, 11 months ago by Anonymous.

  • 2016-10-24 at 3:45 pm
    Support Expired
    #17304
    gaelbergeron
    Participant
    • Topics: 2
    • Replies: 1
    • Total posts: 3
    • Post count: 3

    Hey,

    There are some changes made on the player (JavaScript), coming with the 6.0.0 version of MusicPlay.

    When I install the 6.0.0 version of MusicPlay (and copy the last changes from musicplay-child into my own custom child theme), the player is not working anymore, at least with SoundCloud API.

    Uncaught TypeError: SC.resolve is not a function, from jquery.fullwidthaudioplayer.js (line 4103).

    Not sure if the SoundCloud API has changed or if the cause comes from the jquery plugin, but could you please update the given scripts to work with SoundCloud API again?

    One possible cause could be that the SoundCloud SDK defined in the MusicPlay 6.0.0 theme (framework/common/head line 71, “//connect.soundcloud.com/sdk/sdk-3.1.2.js”) and the one defined in the musicplay-child theme (“//connect.soundcloud.com/sdk.js”) are not the same…

    When I try to use the 3-1-2.js SoundCloud SDK, the JS error does not appear anymore ;
    But I have another error : the player itself is not shown anymore… Which triggers a JavaScript error Uncaught TypeError: Cannot read property 'removeClass' of undefined (jquery.fullwidthaudioplayer.js line 487)

    Could you please update the musicplay-child theme and make sure it works with SoundCloud?

    Also, another point I have, is that the SoundCloud API key is hardcoded in the fullwidthaudioplayer.js file…
    I would prefer to have an option in the WP admin section to set this key.
    Could you make it possible aswell?

    Thanks in advance, this is quite urgent (at least for the first problem, the API-key point is less urgent).

    • This topic was modified 9 years, 11 months ago by gaelbergeron.
    2016-10-24 at 5:04 pm
    #17313
    Fem
    Keymaster
    • Topics: 2
    • Replies: 5215
    • Total posts: 5217
    • Post count: 6003

    Will consider making a fix for GET method instead of post method for the FWAP js file. on line #119. Will release a new version once its tested by tomorrow.

    2016-10-27 at 2:07 pm
    Support Expired
    #17369
    gaelbergeron
    Participant
    • Topics: 2
    • Replies: 1
    • Total posts: 3
    • Post count: 3

    Hey fem,

    I have seen the new version of October 26th, but this fix is not included.

    Could you please just provide some visibility on your work about this one?
    Just tell me when it would be updated, and update the changelogs, style.css files accordingly etc. please?

    Thanks in advance

    2016-10-27 at 3:40 pm
    #17372
    Anonymous
    Inactive
    • Topics: 0
    • Replies: 3227
    • Total posts: 3227
    • Post count: 0

    Might be the files were missed, not uploaded completely I think. Again we have uploaded the theme with all the files.

    2016-11-04 at 5:45 pm
    #17544
    Anonymous
    Inactive
    • Topics: 0
    • Replies: 3227
    • Total posts: 3227
    • Post count: 0

    We are setting this topic to be resolved. If you wish to update this topic please reply here instead of creating another topic.

You must be logged in to reply to this topic.